koma/i3
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Assume xcb_cursor_context_new never fails (#3955)

Browse Source 
According to libxcb-cursor code, the only condition in which
xcb_cursor_context_new() returns a non-zero result is a memory
allocation failure[1].  Thus, it is safe to assume that
xcursor_supported is always true, and remove dead code.

[1]: https://gitlab.freedesktop.org/xorg/lib/libxcb-cursor/blob/0.1.3/cursor/cursor.c#L131-132
This commit is contained in:
xzfc
2020-02-24 07:48:58 +00:00
committed by GitHub
parent 0ba325c5f3
commit 47be36410c
10 changed files with 17 additions and 116 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/startup.c
View File

@ -201,10 +201,7 @@ void start_application(const char *command, bool no_startup_id) {
if (!no_startup_id) {
/* Change the pointer of the root window to indicate progress */
if (xcursor_supported)
xcursor_set_root_cursor(XCURSOR_CURSOR_WATCH);
else
xcb_set_root_cursor(XCURSOR_CURSOR_WATCH);
xcursor_set_root_cursor(XCURSOR_CURSOR_WATCH);
}
}
@ -246,10 +243,7 @@ void startup_monitor_event(SnMonitorEvent *event, void *userdata) {
if (_prune_startup_sequences() == 0) {
DLOG("No more startup sequences running, changing root window cursor to default pointer.\n");
/* Change the pointer of the root window to indicate progress */
if (xcursor_supported)
xcursor_set_root_cursor(XCURSOR_CURSOR_POINTER);
else
xcb_set_root_cursor(XCURSOR_CURSOR_POINTER);
xcursor_set_root_cursor(XCURSOR_CURSOR_POINTER);
}
break;
default: