Match on all criteria even if con_id or con_mark are given.
Previously, if a match specification contained the con_id or con_mark criterion, all other criteria were ignored. However, a user may want to specify one of those two unique identifiers and still specify others as well, for example to match the currently focused window, but only if it has a certain WM_CLASS: [con_id=__focused__ class=special] kill We now check all specified criteria. fixes #2111
This commit is contained in:
51
testcases/t/261-match-con_id-con_mark-combinations.t
Normal file
51
testcases/t/261-match-con_id-con_mark-combinations.t
Normal file
@ -0,0 +1,51 @@
|
||||
#!perl
|
||||
# vim:ts=4:sw=4:expandtab
|
||||
#
|
||||
# Please read the following documents before working on tests:
|
||||
# • http://build.i3wm.org/docs/testsuite.html
|
||||
# (or docs/testsuite)
|
||||
#
|
||||
# • http://build.i3wm.org/docs/lib-i3test.html
|
||||
# (alternatively: perldoc ./testcases/lib/i3test.pm)
|
||||
#
|
||||
# • http://build.i3wm.org/docs/ipc.html
|
||||
# (or docs/ipc)
|
||||
#
|
||||
# • http://onyxneon.com/books/modern_perl/modern_perl_a4.pdf
|
||||
# (unless you are already familiar with Perl)
|
||||
#
|
||||
# Ticket: #2111
|
||||
use i3test;
|
||||
|
||||
my ($ws);
|
||||
|
||||
###############################################################################
|
||||
# Verify that con_id can be combined with other criteria
|
||||
###############################################################################
|
||||
|
||||
$ws = fresh_workspace;
|
||||
open_window(wm_class => 'matchme');
|
||||
|
||||
cmd '[con_id=__focused__ class=doesnotmatch] kill';
|
||||
is(@{get_ws($ws)->{nodes}}, 1, 'window was not killed');
|
||||
|
||||
cmd '[con_id=__focused__ class=matchme] kill';
|
||||
is(@{get_ws($ws)->{nodes}}, 0, 'window was killed');
|
||||
|
||||
###############################################################################
|
||||
# Verify that con_mark can be combined with other criteria
|
||||
###############################################################################
|
||||
|
||||
$ws = fresh_workspace;
|
||||
open_window(wm_class => 'matchme');
|
||||
cmd 'mark marked';
|
||||
|
||||
cmd '[con_mark=marked class=doesnotmatch] kill';
|
||||
is(@{get_ws($ws)->{nodes}}, 1, 'window was not killed');
|
||||
|
||||
cmd '[con_mark=marked class=matchme] kill';
|
||||
is(@{get_ws($ws)->{nodes}}, 0, 'window was killed');
|
||||
|
||||
###############################################################################
|
||||
|
||||
done_testing;
|
Reference in New Issue
Block a user