koma/i3
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve startup sequence termination conditions

Browse Source 
If a window with _NET_STARTUP_ID set is moved to another workspace, it
will delete any associated startup sequence immediately. This will also
occur if a window has a leader with _NET_STARTUP_ID set, if the leader
has no container (never been mapped).

A startup sequence may also be deleted if it's matched by
startup_workspace_for_window() and its 30-second timeout has elapsed.
This commit is contained in:
Deiz
2012-10-03 21:06:04 -04:00
committed by Michael Stapelberg
parent fdcba7b91a
commit cae6fb627f
4 changed files with 166 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
testcases/t/175-startup-notification.t
View File

@ -136,16 +136,49 @@ is_num_children($second_ws, 0, 'still no containers on the second workspace');
is_num_children($first_ws, 2, 'two containers on the first workspace');
######################################################################
# 2) open another window after the startup process is completed
# (should be placed on the current workspace)
# verifies that finishing startup doesn't immediately stop windows
# from being placed on the sequence's workspace, but that moving
# the leader actually deletes the startup sequence mapping
######################################################################
complete_startup();
sync_with_i3;
my $otherwin = open_window;
# Startup has completed but the 30-second deletion time hasn't elapsed,
# so this window should still go on the leader's initial workspace.
$win = open_window({ dont_map => 1, client_leader => $leader });
$win->map;
sync_with_i3;
is_num_children($first_ws, 3, 'three containers on the first workspace');
# Switch to the first workspace and move the focused window to the
# second workspace.
cmd "workspace $first_ws";
cmd "move workspace $second_ws";
is_num_children($second_ws, 1, 'one container on the second workspace');
# Create and switch to a new workspace, just to be safe.
my $third_ws = fresh_workspace;
# Moving the window between workspaces should have immediately
# removed the startup workspace mapping. New windows with that
# leader should be created on the current workspace.
$win = open_window({ dont_map => 1, client_leader => $leader });
$win->map;
sync_with_i3;
is_num_children($third_ws, 1, 'one container on the third workspace');
######################################################################
# 2) open another window after the startup process is completed
# (should be placed on the current workspace)
######################################################################
my $otherwin = open_window;
is_num_children($third_ws, 2, 'two containers on the third workspace');
######################################################################
# 3) test that the --no-startup-id flag for exec leads to no DESKTOP_STARTUP_ID
# environment variable.