Fix segfault when bindsym command is empty (#5001)
Remove end token from BINDCOMMAND fixes i3/i3#5000: bindsym command cannot be empty, because NULL string causes i3 to segfault when copied in configure_binding()
This commit is contained in:
parent
6ab64aa5b7
commit
ce2665ca96
@ -400,8 +400,6 @@ state BINDCOMMAND:
|
||||
->
|
||||
command = string
|
||||
-> call cfg_binding($bindtype, $modifiers, $key, $release, $border, $whole_window, $exclude_titlebar, $command)
|
||||
end
|
||||
-> call cfg_binding($bindtype, $modifiers, $key, $release, $border, $whole_window, $exclude_titlebar, $command)
|
||||
|
||||
################################################################################
|
||||
# Mode configuration
|
||||
|
1
release-notes/bugfixes/7-fix-segfault
Normal file
1
release-notes/bugfixes/7-fix-segfault
Normal file
@ -0,0 +1 @@
|
||||
Fix segfault if command in bindsym is empty
|
31
testcases/t/546-empty-bindcommand.t
Normal file
31
testcases/t/546-empty-bindcommand.t
Normal file
@ -0,0 +1,31 @@
|
||||
#!perl
|
||||
# vim:ts=4:sw=4:expandtab
|
||||
#
|
||||
# Please read the following documents before working on tests:
|
||||
# • https://build.i3wm.org/docs/testsuite.html
|
||||
# (or docs/testsuite)
|
||||
#
|
||||
# • https://build.i3wm.org/docs/lib-i3test.html
|
||||
# (alternatively: perldoc ./testcases/lib/i3test.pm)
|
||||
#
|
||||
# • https://build.i3wm.org/docs/ipc.html
|
||||
# (or docs/ipc)
|
||||
#
|
||||
# • http://onyxneon.com/books/modern_perl/modern_perl_a4.pdf
|
||||
# (unless you are already familiar with Perl)
|
||||
#
|
||||
# Test that i3 doesn't crash if the binding command is empty.
|
||||
# Ticket: #5000
|
||||
|
||||
use i3test i3_autostart => 0;
|
||||
|
||||
my $config = <<EOT;
|
||||
# i3 config file (v4)
|
||||
bindsym X
|
||||
EOT
|
||||
|
||||
my $pid = launch_with_config($config);
|
||||
does_i3_live;
|
||||
|
||||
exit_gracefully($pid);
|
||||
done_testing;
|
Loading…
x
Reference in New Issue
Block a user