koma/i3
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't call con_focus in tree_move

Browse Source 
Fixes:
- Issue where moving an urgent (unfocused) window resets it's urgency
hint.
- Moving an unfocused container to a new parent should not move it to
the top of the focus stack.
This commit is contained in:
Orestis Floros
2017-09-22 04:48:32 +03:00
parent 6222ab1084
commit d66fa51f33
3 changed files with 44 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
testcases/t/113-urgent.t
View File

@ -332,6 +332,34 @@ for ($type = 1; $type <= 2; $type++) {
ok(!$source_ws->{urgent}, 'Source workspace is no longer marked urgent');
is($target_ws->{urgent}, 1, 'Target workspace is now marked urgent');
##############################################################################
# Test that moving an unfocused container doesn't reset its urgency hint.
##############################################################################
$tmp = fresh_workspace;
$win1 = open_window;
$win2 = open_window;
cmd 'split v';
$win3 = open_window;
set_urgency($win1, 1, $type);
sync_with_i3;
my $win1_info;
@content = @{get_ws_content($tmp)};
$win1_info = first { $_->{window} == $win1->id } @content;
ok($win1_info->{urgent}, 'win1 window is marked urgent');
cmd '[id="' . $win1->id . '"] move right';
cmd '[id="' . $win1->id . '"] move right';
@content = @{get_ws_content($tmp)};
$win1_info = first { $_->{window} == $win1->id } @content;
ok($win1_info->{urgent}, 'win1 window is still marked urgent after moving');
cmd '[id="' . $win1->id . '"] focus';
@content = @{get_ws_content($tmp)};
$win1_info = first { $_->{window} == $win1->id } @content;
ok(!$win1_info->{urgent}, 'win1 window is not marked urgent after focusing');
##############################################################################
exit_gracefully($pid);