koma/i3
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use _PATH_BSHELL to ensure using a bourne shell

Browse Source 
[Michael]
This commit should fix problems with people using a non-bourne shell as
login shell, e.g. fish or rc. AFAICT, $SHELL should only be used for
interactive shells, but we just want a bourne shell, not an interactive
shell.
This commit is contained in:
Baptiste Daroussin
2013-11-08 21:13:35 +01:00
committed by Michael Stapelberg
parent 857fc0bf17
commit f691a55923
3 changed files with 6 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/startup.c
View File

@ -17,6 +17,7 @@
#include <sys/types.h>
#include <sys/wait.h>
#include <paths.h>
#define SN_API_NOT_YET_FROZEN 1
#include <libsn/sn-launcher.h>
@ -191,15 +192,7 @@ void start_application(const char *command, bool no_startup_id) {
if (!no_startup_id)
sn_launcher_context_setup_child_process(context);
/* Stores the path of the shell */
static const char *shell = NULL;
if (shell == NULL)
if ((shell = getenv("SHELL")) == NULL)
shell = "/bin/sh";
/* This is the child */
execl(shell, shell, "-c", command, (void*)NULL);
execl(_PATH_BSHELL, _PATH_BSHELL, "-c", command, (void*)NULL);
/* not reached */
}
_exit(0);