diff --git a/src/bindings.c b/src/bindings.c index 823730ff..38002396 100644 --- a/src/bindings.c +++ b/src/bindings.c @@ -198,6 +198,7 @@ void regrab_all_buttons(xcb_connection_t *conn) { */ static Binding *get_binding(i3_event_state_mask_t state_filtered, bool is_release, uint16_t input_code, input_type_t input_type) { Binding *bind; + Binding *result = NULL; if (!is_release) { /* On a press event, we first reset all B_UPON_KEYRELEASE_IGNORE_MODS @@ -271,23 +272,26 @@ static Binding *get_binding(i3_event_state_mask_t state_filtered, bool is_releas if (bind->release == B_UPON_KEYRELEASE && !is_release) { bind->release = B_UPON_KEYRELEASE_IGNORE_MODS; DLOG("marked bind %p as B_UPON_KEYRELEASE_IGNORE_MODS\n", bind); - /* The correct binding has been found, so abort the search, but - * also don’t return this binding, since it should not be executed - * yet (only when the keys are released). */ - bind = TAILQ_END(bindings); - break; - } - - /* Check if the binding is for a press or a release event */ - if ((bind->release == B_UPON_KEYPRESS && is_release) || - (bind->release >= B_UPON_KEYRELEASE && !is_release)) { + if (result) { + break; + } continue; } - break; + /* Check if the binding is for a press or a release event */ + if ((bind->release == B_UPON_KEYPRESS && is_release)) { + continue; + } + + if (is_release) { + return bind; + } else if (!result) { + /* Continue looping to mark needed B_UPON_KEYRELEASE_IGNORE_MODS. */ + result = bind; + } } - return (bind == TAILQ_END(bindings) ? NULL : bind); + return result; } /* diff --git a/testcases/t/258-keypress-release.t b/testcases/t/258-keypress-release.t index b92f723f..766a8a1b 100644 --- a/testcases/t/258-keypress-release.t +++ b/testcases/t/258-keypress-release.t @@ -31,6 +31,11 @@ bindsym Mod1+b nop Mod1+b bindsym --release Mod1+Shift+b nop Mod1+Shift+b release bindsym --release Shift+x nop Shift+x + +# see issue #2733 +# 133 == Mod4 +bindcode 133 nop 133 +bindcode --release 133 nop 133 release EOT use i3test::XTEST; use ExtUtils::PkgConfig; @@ -110,6 +115,25 @@ is(listen_for_binding( ), 'Shift+x', 'triggered the "Shift+x" keybinding by releasing Shift first'); + +is(listen_for_binding( + sub { + xtest_key_press(133); + xtest_sync_with_i3; + }, + ), + '133', + 'triggered the 133 keycode press binding'); + +is(listen_for_binding( + sub { + xtest_key_release(133); + xtest_sync_with_i3; + }, + ), + '133 release', + 'triggered the 133 keycode release binding'); + } done_testing;