Orestis Floros
d134745c4f
Prevent access of freed workspace in _workspace_show
...
The bug triggers when _workspace_show calls tree_close_internal and
old == old_focus. Ie, when the old workspace was empty and needs to be
closed but then is accessed as output_push_sticky_windows's argument:
Breakpoint 1, output_push_sticky_windows (to_focus=0x55555589c8a0) at ../../i3/src/output.c:102
102 con_move_to_workspace(current, visible_ws, true, false, current != to_focus->parent);
(gdb) print con_exists(to_focus)
$1 = false
The access violation can also be prevented by checking if
con_exists(old_focus) but it shouldn't be necessary: the old_focus
container can only be killed when it is an empty workspace.
With --enable-sanitizers this causes i3 to exit but with
--disable-sanitizers the access violation doesn't reliably cause a crash
and the con_move_to_workspace call continues with:
(gdb) print current != to_focus->parent
$2 = 1
Since current->type is CT_FLOATING_CON and to_focus->type is
CT_WORKSPACE, in this specific case ignore_focus would always be true.
So, in this case, passing NULL instead of old_focus to
output_push_sticky_windows doesn't change the behaviour of i3.
Fixes #3075 .
2017-12-10 21:37:43 +02:00
..
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-30 11:41:57 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-10-14 12:27:32 +03:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-30 11:41:57 +02:00
2017-09-24 10:19:50 +02:00
2017-09-27 09:31:39 -07:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-30 11:41:57 +02:00
2017-09-24 10:19:50 +02:00
2017-11-26 18:07:02 +01:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-10-23 21:04:20 +02:00
2017-09-30 11:41:57 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-30 11:41:57 +02:00
2017-09-24 10:19:50 +02:00
2017-09-30 11:41:57 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-30 11:41:57 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-30 11:41:57 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-10-18 02:07:11 +03:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-30 11:41:57 +02:00
2017-09-30 11:41:57 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-30 11:41:57 +02:00
2017-09-24 10:19:50 +02:00
2017-09-30 11:41:57 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-10-05 13:03:33 -07:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-30 11:41:57 +02:00
2017-09-30 11:41:57 +02:00
2017-09-30 11:41:57 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-30 11:28:20 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-10-05 13:03:33 -07:00
2017-09-30 11:41:57 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-12-10 21:37:43 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-12-01 17:11:32 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-28 16:48:50 +03:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-30 11:41:57 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-30 11:41:57 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-12-08 12:16:22 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-24 10:19:50 +02:00
2017-09-22 23:40:41 +00:00
2017-11-28 23:29:47 -08:00